detekt report

Total: 26

complexity: 1

TooManyFunctions: 1 Too many functions inside a/an file/class/object/interface always indicate a violation of the single responsibility principle. Maybe the file/class/object/interface wants to manage too many things at once. Extract functionality which clearly belongs together.

Documentation

subprojects/network-either/common/main/kotlin/com/javiersc/network/either/NetworkEither.kt:8:21Class 'NetworkEither' with '21' functions detected. Defined threshold inside classes is set to '11'

   5 import arrow.core.right
   6 import kotlin.contracts.contract
   7 
   8 public sealed class NetworkEither<out F, out S> {
   9 
  10     public sealed class Failure<out F> : NetworkEither<F, Nothing>() {
  11

exceptions: 5

SwallowedException: 2 The caught exception is swallowed. The original exception could be lost.

Documentation

subprojects/network-either/common/main/kotlin/com/javiersc/network/either/ktor/_internal/interceptExceptionsAndReplaceWithNetworkEitherFailures.kt:14:22The caught exception is swallowed. The original exception could be lost.

  11         if (isNetAvailable()) {
  12             try {
  13                 proceed()
  14             } catch (throwable: Throwable) {
  15                 proceedWith(fakeHttpFailureClientCall(client))
  16             }
  17         } else {

subprojects/network-either/common/main/kotlin/com/javiersc/network/either/ktor/_internal/interceptExceptionsAndReplaceWithNetworkEitherFailures.kt:20:22The caught exception is swallowed. The original exception could be lost.

  17         } else {
  18             try {
  19                 proceedWith(fakeLocalFailureClientCall(client))
  20             } catch (throwable: Throwable) {
  21                 proceedWith(fakeLocalFailureClientCall(client))
  22             }
  23         }

TooGenericExceptionCaught: 3 The caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled.

Documentation

subprojects/network-either/common/main/kotlin/com/javiersc/network/either/ktor/_internal/interceptBeforeTransformAndReplaceContainerWithNetowrkEitherType.kt:35:18The caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled.

  32 
  33         try {
  34             proceedWith(modifiedContainer)
  35         } catch (throwable: Throwable) {
  36             val typeInfo = typeInfo<NetworkEither.Failure<Nothing>>()
  37             val networkEither: NetworkEither<Any, Nothing> = unknownFailure(throwable)
  38             proceedWith(HttpResponseContainer(typeInfo, networkEither))

  11         if (isNetAvailable()) {
  12             try {
  13                 proceed()
  14             } catch (throwable: Throwable) {
  15                 proceedWith(fakeHttpFailureClientCall(client))
  16             }
  17         } else {

  17         } else {
  18             try {
  19                 proceedWith(fakeLocalFailureClientCall(client))
  20             } catch (throwable: Throwable) {
  21                 proceedWith(fakeLocalFailureClientCall(client))
  22             }
  23         }

naming: 18

MatchingDeclarationName: 1 If a source file contains only a single non-private top-level class or object, the file name should reflect the case-sensitive name plus the .kt extension.

Documentation

subprojects/resource-either/common/main/kotlin/com/javiersc/resource/either/Resource.kt:10:21The file name 'Resource' does not match the name of the single top-level declaration 'ResourceEither'.

   7 import arrow.core.right
   8 import kotlin.contracts.contract
   9 
  10 public sealed class ResourceEither<out F, out S> {
  11 
  12     public abstract val isLoading: Boolean
  13

PackageNaming: 17 Package names should match the naming convention set in the configuration.

Documentation

subprojects/network-either/common/main/kotlin/com/javiersc/network/either/ktor/_internal/HttpStatusCodeExtensions.kt:1:1Package name should match the pattern: [a-z]+(\.[a-z][A-Za-z0-9]*)*
```
   1 package com.javiersc.network.either.ktor._internal
   2 
   3 import io.ktor.http.Headers
   4 import io.ktor.http.HttpStatusCode
```
subprojects/network-either/common/main/kotlin/com/javiersc/network/either/ktor/_internal/NetworkEitherFailureOutgoings.kt:1:1Package name should match the pattern: [a-z]+(\.[a-z][A-Za-z0-9]*)*
```
   1 package com.javiersc.network.either.ktor._internal
   2 
   3 import io.ktor.http.ContentType
   4 import io.ktor.http.Headers
```

subprojects/network-either/common/main/kotlin/com/javiersc/network/either/ktor/_internal/PipelineContextExtensions.kt:3:1Package name should match the pattern: [a-z]+(\.[a-z][A-Za-z0-9]*)*

   1 @file:Suppress("MagicNumber")
   2 
   3 package com.javiersc.network.either.ktor._internal
   4 
   5 import com.javiersc.kotlin.stdlib.secondOrNull
   6 import com.javiersc.network.either.NetworkEither

subprojects/network-either/common/main/kotlin/com/javiersc/network/either/ktor/_internal/fakeFailureHttpClientCall.kt:1:1Package name should match the pattern: [a-z]+(\.[a-z][A-Za-z0-9]*)*
```
   1 package com.javiersc.network.either.ktor._internal
   2 
   3 import io.ktor.client.HttpClient
   4 import io.ktor.client.call.HttpClientCall
```
subprojects/network-either/common/main/kotlin/com/javiersc/network/either/ktor/_internal/interceptBeforeTransformAndReplaceContainerWithNetowrkEitherType.kt:1:1Package name should match the pattern: [a-z]+(\.[a-z][A-Za-z0-9]*)*
```
   1 package com.javiersc.network.either.ktor._internal
   2 
   3 import com.javiersc.network.either.NetworkEither
   4 import com.javiersc.network.either.NetworkEither.Companion.localFailure
```
subprojects/network-either/common/main/kotlin/com/javiersc/network/either/ktor/_internal/interceptExceptionsAndReplaceWithNetworkEitherFailures.kt:1:1Package name should match the pattern: [a-z]+(\.[a-z][A-Za-z0-9]*)*
```
   1 package com.javiersc.network.either.ktor._internal
   2 
   3 import io.ktor.client.HttpClient
   4 import io.ktor.client.request.HttpSendPipeline
```

subprojects/network-either/common/main/kotlin/com/javiersc/network/either/ktor/_internal/interceptResponsesAndReplaceWithNetworkEither.kt:1:1Package name should match the pattern: [a-z]+(\.[a-z][A-Za-z0-9]*)*

   1 package com.javiersc.network.either.ktor._internal
   2 
   3 import com.javiersc.network.either.NetworkEither
   4 import com.javiersc.network.either.NetworkEither.Companion.httpFailure

subprojects/network-either/common/test/kotlin/com/javiersc/network/either/_config/fakes/CodeArb.kt:1:1Package name should match the pattern: [a-z]+(\.[a-z][A-Za-z0-9]*)*
```
   1 package com.javiersc.network.either._config.fakes
   2 
   3 import io.kotest.property.Arb
   4 import io.kotest.property.arbitrary.filter
```

subprojects/network-either/common/test/kotlin/com/javiersc/network/either/_config/fakes/Headers.kt:1:1Package name should match the pattern: [a-z]+(\.[a-z][A-Za-z0-9]*)*

   1 package com.javiersc.network.either._config.fakes
   2 
   3 import com.javiersc.network.either.Headers
   4 import com.javiersc.network.either._config.readResource

subprojects/network-either/common/test/kotlin/com/javiersc/network/either/_config/fakes/Json.kt:1:1Package name should match the pattern: [a-z]+(\.[a-z][A-Za-z0-9]*)*
```
   1 package com.javiersc.network.either._config.fakes
   2 
   3 import kotlinx.serialization.json.Json
   4 
```
subprojects/network-either/common/test/kotlin/com/javiersc/network/either/_config/fileSystem.kt:1:1Package name should match the pattern: [a-z]+(\.[a-z][A-Za-z0-9]*)*
```
   1 package com.javiersc.network.either._config
   2 
   3 import okio.FileSystem
   4 
```
subprojects/network-either/common/test/kotlin/com/javiersc/network/either/_config/models/DogDTO.kt:1:1Package name should match the pattern: [a-z]+(\.[a-z][A-Za-z0-9]*)*
```
   1 package com.javiersc.network.either._config.models
   2 
   3 import kotlinx.serialization.Serializable
   4 
```
subprojects/network-either/common/test/kotlin/com/javiersc/network/either/_config/models/ErrorDTO.kt:1:1Package name should match the pattern: [a-z]+(\.[a-z][A-Za-z0-9]*)*
```
   1 package com.javiersc.network.either._config.models
   2 
   3 import kotlinx.serialization.Serializable
   4 
```
subprojects/network-either/common/test/kotlin/com/javiersc/network/either/_config/readResource.kt:1:1Package name should match the pattern: [a-z]+(\.[a-z][A-Za-z0-9]*)*
```
   1 package com.javiersc.network.either._config
   2 
   3 import okio.Path
   4 import okio.Path.Companion.toPath
```

subprojects/network-either/jvm/test/kotlin/com/javiersc/network/either/_config/DogService.kt:1:1Package name should match the pattern: [a-z]+(\.[a-z][A-Za-z0-9]*)*

   1 package com.javiersc.network.either._config
   2 
   3 import com.jakewharton.retrofit2.converter.kotlinx.serialization.asConverterFactory
   4 import com.javiersc.network.either.NetworkEither

subprojects/network-either/jvm/test/kotlin/com/javiersc/network/either/_config/MockResponseUtil.kt:1:1Package name should match the pattern: [a-z]+(\.[a-z][A-Za-z0-9]*)*

   1 package com.javiersc.network.either._config
   2 
   3 import com.javiersc.network.either.Headers
   4 import org.mockserver.model.HttpResponse

subprojects/network-either/jvm/test/kotlin/com/javiersc/network/either/_config/fileSystem.jvm.kt:1:1Package name should match the pattern: [a-z]+(\.[a-z][A-Za-z0-9]*)*
```
   1 package com.javiersc.network.either._config
   2 
   3 import okio.FileSystem
   4 
```

performance: 2

SpreadOperator: 2 In most cases using a spread operator causes a full copy of the array to be created before calling a method. This may result in a performance penalty.

Documentation

subprojects/network-either/jvm/main/kotlin/com/javiersc/network/either/internal/utils/RetrofitUtils.kt:16:22In most cases using a spread operator causes a full copy of the array to be created before calling a method. This may result in a performance penalty.

  13     get() = code() toHttpStatusCode message()
  14 
  15 internal val HttpException.headers: Headers
  16     get() = headersOf(*response()?.headers().toOkHttpHeaders())
  17 
  18 internal val Response<*>.headers: Headers
  19     get() = headersOf(*headers().toOkHttpHeaders())

subprojects/network-either/jvm/main/kotlin/com/javiersc/network/either/internal/utils/RetrofitUtils.kt:19:22In most cases using a spread operator causes a full copy of the array to be created before calling a method. This may result in a performance penalty.

  16     get() = headersOf(*response()?.headers().toOkHttpHeaders())
  17 
  18 internal val Response<*>.headers: Headers
  19     get() = headersOf(*headers().toOkHttpHeaders())
  20 
  21 private fun okhttp3.Headers?.toOkHttpHeaders(): Array<Pair<String, List<String>>> {
  22     return this?.toMultimap()?.map { header -> header.key to header.value }?.toTypedArray()

Metrics

Complexity Report

Findings

complexity: 1

exceptions: 5

naming: 18

performance: 2